On 27 July 2016 at 10:17, Andrew Borodin <boro...@octonica.com> wrote: >> if (accum->maxdig > (INT_MAX - INT_MAX / NBASE) / (NBASE - 1)) > Woth noting that (INT_MAX - INT_MAX / NBASE) / (NBASE - 1) == INT_MAX > / NBASE for any NBASE > 1
Interesting. I think it's clearer the way it is in mul_var() though, because the intention is to avoid letting digits exceed INT_MAX - INT_MAX/NBASE, so that there is no danger of overflow in the carry propagation step. The long form makes that clearer (and is just as efficient, since these expressions will be evaluated by the preprocessor). Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
