On Thu, Aug 4, 2016 at 4:38 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> Andreas, with the patch attached is the assertion still triggered?
>
> Thoughts from others are welcome as well.

Self review:
      * of streaming base backups currently in progress. forcePageWrites is set
      * to true when either of these is non-zero. lastBackupStart is the latest
      * checkpoint redo location used as a starting point for an online backup.
+     * exclusiveBackupStarted is true while pg_start_backup() is being called
+     * during an exclusive backup.
      */
     bool        exclusiveBackup;
     int            nonExclusiveBackups;
     XLogRecPtr    lastBackupStart;
+    bool        exclusiveBackupStarted;
It would be better to just use one variable that uses an enum to track
the following states of an exclusive backup: none, starting and
in-progress.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to