On Thu, Aug 4, 2016 at 6:56 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, Aug 4, 2016 at 2:34 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: >> Michael Paquier wrote: >>> On Wed, Aug 3, 2016 at 7:21 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> >>> wrote: >> >>> > Why not capture both items in a single select, such as in the attached >>> > patch? >>> >>> Let me test this.... >>> [... A while after ...] >>> This looks to work properly. 12 runs in a row have passed. >> >> Okay, applied that way. >> >> BTW, one-line long queries look awful in that perl code. I don't >> propose to change anything now, but I propose that long queries are >> split using here-docs in new code, >> >> $node->safe_psql(<<EQ); >> SELECT foo >> FROM bar >> EQ > > Yep, that would be a good idea. I didn't know this grammar existed. Or > use qq() directly.
hamster has not failed even once for two weeks now, so I think that we're good. Let's see if the problem with pg_basebackup pops up once again. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
