On Mon, Aug 22, 2016 at 10:04 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Aug 22, 2016 at 6:06 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Tue, Aug 23, 2016 at 12:07 AM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >>> + int control_slot = -1; >>> ... >>> + if (control_slot == -1) >>> + elog(ERROR, "cannot unpin unknown segment handle"); >>> >>> Isn't it better to use INVALID_CONTROL_SLOT for control_slot and use >>> datatype as uint32 (same is used for dsm_segment->control_slot and >>> nitems)? >> >> Yes, it is better. New version attached. >> > > This version of patch looks good to me. I have marked it as Ready For > Committer.
Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
