On Thu, Aug 25, 2016 at 6:54 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Amit Kapila wrote: >> On Wed, Aug 24, 2016 at 11:46 PM, Alvaro Herrera >> <alvhe...@2ndquadrant.com> wrote: > >> > Can you split the new xlog-related stuff to a new file, say hash_xlog.h, >> > instead of cramming it in hash.h? Removing the existing #include >> > "xlogreader.h" from hash.h would be nice. I volunteer for pushing any >> > preliminary header cleanup commits. >> >> So, what you are expecting here is that we create hash_xlog.h and move >> necessary functions like hash_redo(), hash_desc() and hash_identify() >> to it. Then do whatever else is required to build it successfully. >> Once that is done, I can build my patches on top of it. Is that >> right? If yes, I can work on it. > > Yes, thanks. >
How about attached? If you want, I think we can one step further and move hash_redo to a new file hash_xlog.c which is required for main patch, but we can leave it for later as well. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
add_hash_xlog-v1.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
