On Mon, Jul 18, 2016 at 3:54 PM, Emre Hasegeli <e...@hasegeli.com> wrote: > My progress so far is attached as 2 patches. First one introduces an > header file for adt/float.c. Second one refactors the geometric > operations.
The first patch fails to apply due to bit-rot. That's easy enough to correct, but then it runs into warnings on make: btree_gin.c: In function ‘leftmostvalue_float4’: btree_gin.c:234:2: error: implicit declaration of function ‘get_float4_infinity’ [-Werror=implicit-function-declaration] return Float4GetDatum(-get_float4_infinity()); ^ btree_gin.c: In function ‘leftmostvalue_float8’: btree_gin.c:242:2: error: implicit declaration of function ‘get_float8_infinity’ [-Werror=implicit-function-declaration] return Float8GetDatum(-get_float8_infinity()); ^ Please fix. Something to consider before posting new version -- should we change some of those macros to static inline (in the .h files) to avoid double-evaluation hazards? They might perform as well or even better that way, and remove a subtle programmer foot-gun. Changing status to "Waiting on Author". -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
