Heikki Linnakangas <hlinn...@iki.fi> writes: > BTW, I would be OK with the bit-twiddling hack, if we had an autoconf > check for IEEE 754 floats, and a graceful fallback for other systems.
I would still object to the version submitted, on the grounds of the compiler warnings it causes. Possibly those could be avoided with a union, though; Float4GetDatum doesn't produce such warnings. BTW, would someone explain to me why using a float here will not fail catastrophically for inputs outside the range of float? Cubes are based on doubles, not floats. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers