On 2016-09-08 20:15:46 -0400, Peter Eisentraut wrote: > On 9/8/16 6:04 PM, Alvaro Herrera wrote: > > Andres Freund wrote: > >> On 2016-09-08 18:13:06 -0300, Alvaro Herrera wrote: > >>> I suppose -I$(srcdir) should be fine. (Why the quotes?) > >> > >> Because quoting correctly seems like a good thing to do? Most people > >> won't have whitespace in there, but it doesn't seem impossible? > > > > Well, I think they are used without quotes in so many places that doing > > it here seems rather pointless. > > We don't support build directories with spaces in them, but we support > installation directories with spaces in them. So I guess that means > your point is valid.
Even if not necessary in this specific case, I personally think it's just a good to quote halfway sensibly. Especially when it's trivial to do so. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
