On Sat, Sep 10, 2016 at 3:55 AM, Adam Brightwell <adam.brightw...@crunchydata.com> wrote: >> Perhaps we should extend rowsecurity test with a more comprehensive >> set of tests rather than just fix the COPY one? > > I think more tests that provide value are always a *good* thing, > however, would argue that other tests 'unrelated' to this fix are more > of a TODO item than something to include with this fix. Though, I am > certainly willing to attempt to find/add more test cases around this > specific functionality if that is desired.
Looking for and improving test coverage for RLS is a good suggestion, but let's not link the fate of the issue reported here with this requirement. I have spent some time looking at this patch and this looks in rather good shape to me (you even remembered to use the prefix regress_* for the role name that you are adding!). So I have marked this bug fix as ready for committer. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
