On Tue, Sep 13, 2016 at 3:50 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > Add some tests. At least test that one entry from the directory list > and one entry from the files list is not contained in the backup > result. Testing the symlink handling would also be good. (The > pg_basebackup tests claim that Windows doesn't support symlinks and > therefore skip all the symlink tests. That seems a bit at odds with > your code handling symlinks on Windows.)
The code proposed needs to support junction points on Windows so from this side of things everything is fine. What is lacking here is support for symlink() in perl for Windows, and that's why the tests are skipped. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
