Tom Lane wrote: > I think changing the hook API is a pretty reasonable thing to do here > (though I'd make it its own patch and then add the autocommit change > on top). When was the last time you actually wanted to set VERBOSITY > to "fubar"?
It looks easy to make the hooks return a bool, and when returning false, cancel the assignment of the variable. I volunteer to write that patch. It would close the hazard that exists today of an internal psql flag getting decorrelated from the corresponding variable, due to feeding it with a wrong value, or in the case of autocommit, in the wrong context. Also with that, the behavior of ParseVariableBool() assuming "on" when it's being fed with junk could be changed. Instead it could just reject the assignment rather than emit a warning, and both the internal flag and the variable would keep the values they had at the point of the bogus assignment. Best regards, -- Daniel Vérité PostgreSQL-powered mailer: http://www.manitou-mail.org Twitter: @DanielVerite -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
