Hi Stephen,
> 4. It will be good if we have an example for this in section
> > "5.7. Row Security Policies"
>
> I haven't added one yet, but will plan to do so.
>
> I think you are going to add this in this patch itself, right?
I have reviewed your latest patch and it fixes almost all my review
comments.
Also I am agree with your responses for couple of comments like response on
ALTER POLICY and tab completion. No issues with that.
However in documentation, PERMISSIVE and RESTRICTIVE are actually literals
and not parameters as such. Also can we combine these two options into one
like below (similar to how we document CASCADE and RESTRICT for DROP
POLICY):
<varlistentry>
<term><literal>PERMISSIVE</literal></term>
<term><literal>RESTRICTIVE</literal></term>
<listitem>
<para>
... explain PERMISSIVE ...
</para>
<para>
... explain RESTRICTIVE ...
</para>
</listitem>
</varlistentry>
Apart from this changes look excellent to me.
Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
