Hello. First patch fixes:
``` pg_filedump.c: In function ‘FormatItem’: pg_filedump.c:994:18: error: ‘SizeOfIptrData’ undeclared (first use in this function) if (numBytes < SizeOfIptrData) ``` After 8023b582 there is no more SizeOfIptrData macro. Second patch fixes Makefile. On some systems (notably FreeBSD) there is no `gcc` by default. Using `cc` is a more crossplatform way to compile a project. -- Best regards, Aleksander Alekseev
diff --git a/pg_filedump.c b/pg_filedump.c index 2f2cd53..ba55711 100644 --- a/pg_filedump.c +++ b/pg_filedump.c @@ -991,7 +991,7 @@ FormatItem(unsigned int numBytes, unsigned int startIndex, if (formatAs == ITEM_INDEX) { /* It is an IndexTuple item, so dump the index header */ - if (numBytes < SizeOfIptrData) + if (numBytes < sizeof(ItemPointerData)) { if (numBytes) {
diff --git a/Makefile b/Makefile index 29c1057..b30dbec 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ # note this must match version macros in pg_filedump.h FD_VERSION=9.6.0 -CC=gcc +CC=cc CFLAGS=-g -O -Wall -Wmissing-prototypes -Wmissing-declarations # If working with a PG source directory, point PGSQL_INCLUDE_DIR to its
signature.asc
Description: PGP signature