On 2016/10/17 10:22, Haribabu Kommi wrote:
On Fri, Oct 14, 2016 at 7:48 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp <mailto:pokale_vinayak...@lab.ntt.co.jp>> wrote:On 2016/10/12 12:21, Haribabu Kommi wrote:I tried changing the pg_stat_sql into row mode and ran the regress suite to add different type of SQL commands to the view and ran the pgbench test on my laptop to find out any performance impact with this patch. HEAD PATCH pgbench - select 828 816 Here I attached the pg_stat_sql patch to keep track of all SQL commands based on the commandTag and their counts. I attached the result of this view that is run on the database after "make installcheck" just for reference.Some comments: I think we can use pgstat_* instead of pgstat* for code consistency. +static HTAB *pgStatBackendSql = NULL; How about *pgstat_backend_sql +HTAB *pgStatSql = NULL; How about *pgstat_sql Changed. +static void pgstat_recv_sqlstmt(PgStat_MsgSqlstmt * msg, int len); How about PgStat_MsgSqlstmt *msg instead of PgStat_MsgSqlstmt * msg Added the typdef into typdef.list file so this problem never occurs. +typedef struct PgStatSqlstmtEntry How about PgStat_SqlstmtEntry +typedef struct PgStatMsgSqlstmt How about PgStat_MsgSqlstmt changed. Updated patch is attached.
The updated patch gives following error. Error:../../../../src/include/pgstat.h:557: error: ‘PgStatSqlstmtEntry’ undeclared here (not in a function)
- ((PGSTAT_MSG_PAYLOAD - sizeof(int)) / sizeof(PgStatSqlstmtEntry)) + ((PGSTAT_MSG_PAYLOAD - sizeof(int)) / sizeof(PgStat_SqlstmtEntry)) The attached patch fixed the error. Regards, Vinayak Pokale
pg_stat_sql_row_mode_2.patch
Description: application/download
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
