On Tue, Oct 25, 2016 at 2:52 PM, Michael Paquier <michael.paqu...@gmail.com> wrote:
> On Tue, Oct 25, 2016 at 7:12 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > On Mon, Oct 24, 2016 at 7:46 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wrote: > >> > >> On Sun, Oct 23, 2016 at 10:28 PM, Magnus Hagander <mag...@hagander.net> > >> wrote: > >> + if (format == 'p') > >> + stream.walmethod = CreateWalDirectoryMethod(param->xlog, > do_sync); > >> + else > >> + stream.walmethod = CreateWalTarMethod(param->xlog, > >> compresslevel, do_sync); > >> LogStreamerMain() exits immediately once it is done, but I think that > >> we had better be tidy here and clean up the WAL methods that have been > >> allocated. I am thinking here about a potentially retry method on > >> failure, though the best shot in this area would be with > >> ReceiveXlogStream(). > > > > Wouldn't the same be needed in pg_receivexlog.c in that case? > > Oops, missed that. Thanks for the extra checks. Attached is an updated > patch. > Thanks, applied and pushed. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
