On Mon, Oct 31, 2016 at 9:53 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/30/16 12:50 PM, Anastasia Lubennikova wrote: >> The patches are good, no complaints. >> But again, I have the same question. >> I was confused, why do we always dump sequence data, >> because I'd overlooked the --sequence-data key. I'd rather leave this >> option, >> because it's quite non intuitive behaviour... >> /* dump sequence data even in schema-only mode */ > > Here are rebased patches. > > Regarding your question: The initial patch had a separate option for > this behavior, which was then used by pg_upgrade. It was commented that > this option is not useful outside of pg_upgrade, so it doesn't need to > be exposed as a user-facing option. I agreed with that and removed the > option. We can always add the option back easily if someone really > wants it, but so far no use case has been presented. So I suggest we > proceed with this proposal ignoring whether this option is exposed or not.
I had a look at those fresh patches, and 0001 looks like a good thing. This makes the separation between sequences and table data dump cleaner. I ran some tests with pg_upgrade and 0002, and things are clear. And +1 for the way done in the patch, aka no options of pg_dump exposed to user, still keep the option tracking as a separate value. One small thing here: static void -getTableData(DumpOptions *dopt, TableInfo *tblinfo, int numTables, bool oids) +getTableData(DumpOptions *dopt, TableInfo *tblinfo, int numTables, bool oids, char relkind) { int i; for (i = 0; i < numTables; i++) { - if (tblinfo[i].dobj.dump & DUMP_COMPONENT_DATA) + if (tblinfo[i].dobj.dump & DUMP_COMPONENT_DATA && + (!relkind || tblinfo[i].relkind == relkind)) makeTableDataInfo(dopt, &(tblinfo[i]), oids) One idea here would be to have an extra routine, getSequenceData and not extend getTableData() with relkind as extra argument. I am fine with the way patch does things, so I just switched the patch as ready for committer. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers