On Thu, Nov 3, 2016 at 6:48 PM, Kuntal Ghosh <kuntalghosh.2...@gmail.com> wrote: > So, whenever we are required to use bimg_info flag, we should make > sure that has_image > is set.
OK, we are taking past each other here. There are two possible patterns: - has_image is set, not apply, meaning that the image block is used for consistency checks. - has_image is set, as well as apply, meaning that the block needs to be applied at redo. So I mean exactly the same thing as you do. The point I am trying to raise is that it would be meaningful to put in some code paths checks of the type (apply && !has_image) and ERROR on them. Perhaps we could just do that in xlogreader.c though. If having those checks external to xlogreader.c makes sense, then using separate macros is more portable. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
