On Fri, Nov 4, 2016 at 1:44 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 10/31/16 1:58 AM, Michael Paquier wrote: >> In info.c, missing some entries in report_unmatched_relation() when >> reporting unmatching relations? > > Yeah, that will need a bit of a rewrite, so FIXME later?
This patch not being complicated, so I would vote for those being addressed now so as they are not forgotten even if there is a FIXME flag added. Perhaps you don't think so, and as that's a minor issue I'll be fine with your judgement as well. >> In util.c, doesn't pg_log_v() need to handle strings used in fprintf? > > Which specific lines do you have in mind? The verbose logs at the top. In pg_rewind for example those logs are getting translated via the pg_log() calls used with PG_DEBUG. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
