On Wed, Nov 9, 2016 at 12:00 PM, Robert Haas <robertmh...@gmail.com> wrote: > In this latest patch set: > > src/backend/parser/parse_utilcmd.c:3194: indent with spaces. > + *rdatum; > > With all patches applied, "make check" fails with a bunch of diffs > that look like this: > > Check constraints: > - "pt1chk2" CHECK (c2 <> ''::text) > "pt1chk3" CHECK (c2 <> ''::text)
And the pg_upgrade test also fails: Done + pg_dumpall -f /Users/rhaas/pgsql/src/bin/pg_upgrade/tmp_check/dump2.sql + pg_ctl -m fast stop waiting for server to shut down.... done server stopped + set +x Files /Users/rhaas/pgsql/src/bin/pg_upgrade/tmp_check/dump1.sql and /Users/rhaas/pgsql/src/bin/pg_upgrade/tmp_check/dump2.sql differ dumps were not identical make[2]: *** [check] Error 1 make[1]: *** [check-pg_upgrade-recurse] Error 2 make: *** [check-world-src/bin-recurse] Error 2 [rhaas pgsql]$ diff /Users/rhaas/pgsql/src/bin/pg_upgrade/tmp_check/dump1.sql /Users/rhaas/pgsql/src/bin/pg_upgrade/tmp_check/dump2.sql 6403d6402 < c text 8736,8737c8735 < CONSTRAINT blocal CHECK (((b)::double precision < (1000)::double precision)), < CONSTRAINT bmerged CHECK (((b)::double precision > (1)::double precision)) --- > CONSTRAINT blocal CHECK (((b)::double precision < (1000)::double > precision)) For future revisions, please make sure "make check-world" passes before posting. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
