On 11/10/2016 05:29 AM, Peter Eisentraut wrote:
On 11/8/16 6:43 PM, Andreas Karlsson wrote:
- A worry is that it might get a bit confusing to have both the future
catalog pg_sequence and the view pg_sequences.
We already have this in other cases: pg_index/pg_indexes,
pg_user_mapping/pg_user_mappings. It's an established naming system by now.
Then I am fine with it.
- I think it would be useful to include is_cycled in the view.
It's there under the name "cycle".
You are right, my bad, I managed to confuse myself.
- Shouldn't last_value be NULL directly after we have created the
sequence but nobody has called nextval() yet?
- I noticed that last_value includes the cached values, but that also
seems to me like the correct thing to do.
The documentation now emphasizes that this is the value stored on disk.
This matches what Oracle does.
We also store is_called on disk, I think that if is_called is false then
last_value should be NULL. Either that or we should add is_called.
I will give the patch another review some time this week when i can find
the time.
Andreas
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
