On 18 November 2016 at 08:15, Craig Ringer <cr...@2ndquadrant.com> wrote:
> On 18 November 2016 at 07:10, Michael Paquier <michael.paqu...@gmail.com>
> wrote:
>> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <cr...@2ndquadrant.com> wrote:
>>> I wasted a bunch of time getting set up to test for such an ancient
>>> Perl and would love to save the next person along the hassle by
>>> documenting the easy way.
>>
>> It looks sensible to mention that in the README, so +1.
>>
>> By the way, would it matter to mention ways to install perlbrew? For
>> example, I just bumped into http://install.perlbrew.pl by looking
>> around, though I don't doubt that most people would just use cpan with
>> "install App::perlbrew" for example. For OSX users with brew and
>> without macports that would matter.
>
> The docs linked mention it, so I figured that'd probably do. Though I
> notice it's only mentioned in the "configuration" section not under
> "installation", so maybe it's worth adding yeah.
Updated docs patch. Since configure checks for 5.8.0 that's what's
specified. Anyone who wants to argue about the actual version we
_should_ target can do so elsewhere, all I'm interested in is what we
_do_ officially target so I can document this.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From e659e76ed2a1049ce5f7428fb6a8ef9deaef3ca6 Mon Sep 17 00:00:00 2001
From: Craig Ringer <cr...@2ndquadrant.com>
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.0 is required
---
src/test/perl/README | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..d2550a9 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,21 @@ For available PostgreSQL-specific test methods and some example tests read the
perldoc for the test modules, e.g.:
perldoc src/test/perl/PostgresNode.pm
+
+Required Perl
+-------------
+
+Tests must run on perl 5.8.0 and newer. perlbrew is a good way to obtain
+such a Perl; see http://install.perlbrew.pl .
+
+Just install and
+
+ perlbrew --force install 5.8.0
+ perlbrew use 5.8.0
+ perlbrew install-cpanm
+ cpanm install IPC::Run
+
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+
+ grep ^PERL= config.log
--
2.5.5
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
