Michael Paquier wrote: > Nit: I did not look at the patch in details, > but I find the size of the latest version sent, 167kB, scary as it > complicates review and increases the likeliness of bugs.
Here's the stat. Note that removing the functionality as discussed would remove all of xpath_parser.c but I think the rest of it remains pretty much unchanged. So it's clearly a large patch, but there are large docs and tests too, not just code. doc/src/sgml/func.sgml | 376 ++++++++++++++++++--- src/backend/executor/execQual.c | 335 +++++++++++++++++++ src/backend/executor/execTuples.c | 42 +++ src/backend/nodes/copyfuncs.c | 66 ++++ src/backend/nodes/equalfuncs.c | 51 +++ src/backend/nodes/nodeFuncs.c | 100 ++++++ src/backend/nodes/outfuncs.c | 51 +++ src/backend/nodes/readfuncs.c | 42 +++ src/backend/optimizer/util/clauses.c | 33 ++ src/backend/parser/gram.y | 181 ++++++++++- src/backend/parser/parse_coerce.c | 33 +- src/backend/parser/parse_expr.c | 182 +++++++++++ src/backend/parser/parse_target.c | 7 + src/backend/utils/adt/Makefile | 2 +- src/backend/utils/adt/ruleutils.c | 100 ++++++ src/backend/utils/adt/xml.c | 610 +++++++++++++++++++++++++++++++++++ src/backend/utils/adt/xpath_parser.c | 337 +++++++++++++++++++ src/backend/utils/fmgr/funcapi.c | 13 + src/include/executor/executor.h | 1 + src/include/executor/tableexpr.h | 69 ++++ src/include/funcapi.h | 1 - src/include/nodes/execnodes.h | 31 ++ src/include/nodes/nodes.h | 4 + src/include/nodes/parsenodes.h | 21 ++ src/include/nodes/primnodes.h | 40 +++ src/include/parser/kwlist.h | 3 + src/include/parser/parse_coerce.h | 4 + src/include/utils/xml.h | 2 + src/include/utils/xpath_parser.h | 24 ++ src/test/regress/expected/xml.out | 415 ++++++++++++++++++++++++ src/test/regress/expected/xml_1.out | 323 +++++++++++++++++++ src/test/regress/expected/xml_2.out | 414 ++++++++++++++++++++++++ src/test/regress/sql/xml.sql | 170 ++++++++++ 33 files changed, 4019 insertions(+), 64 deletions(-) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
