On 11/29/16 2:53 PM, Andres Freund wrote: > On 2016-11-29 12:16:37 -0500, Peter Eisentraut wrote: >> On 11/12/16 10:38 AM, Andres Freund wrote: >>>> /* >>>> * Also forbid matching an any-encoding entry. This test of course is >>>> not >>>> * backed up by the unique index, but it's not a problem since we don't >>>> * support adding any-encoding entries after initdb. >>>> */ >>> >>> Note that this isn't true anymore... >> >> I think this is still correct, because the collation import does not >> produce any any-encoding entries (collencoding = -1). > > Well, the comment "don't support adding any-encoding entries after > initdb." is now wrong.
I think there is a misunderstanding. The comment says that we don't support adding encodings that have collencoding = -1 after initdb. That is still true. Note that the original comment as two "any"'s. With this patch, we would now support adding collations with collencoding <> -1 after initdb. > >>>> + >>>> +Datum pg_import_system_collations(PG_FUNCTION_ARGS); >>>> + >>>> +Datum >>>> +pg_import_system_collations(PG_FUNCTION_ARGS) >>>> +{ >>> >>> Uh? >> >> Required to avoid compiler warning about missing prototype. > > It seems not to be project style to have prototypes in the middle of the > file... OK, will fix. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers