Sure - I figured since it's a 1-line function, someone would just write it themselves in the next release. But here it is attached. I'm not sure exactly how you like your patches submitted, so here is a zip file with the modified libpq-fe.h and fe-exec.c files.

The only change is the addition of:
PQescapeByteaFree(unsigned char *);

-Dave





From: Joe Conway <[EMAIL PROTECTED]>
To: Key88 SF <[EMAIL PROTECTED]>
CC: [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: Re: [HACKERS] PQescapeBytea on Win32
Date: Mon, 17 Mar 2003 21:41:26 -0800
MIME-Version: 1.0
Received: from relay1.pgsql.com ([64.49.215.129]) by mc8-f12.law1.hotmail.com with Microsoft SMTPSVC(5.0.2195.5600); Mon, 17 Mar 2003 21:43:59 -0800
Received: from postgresql.org (postgresql.org [64.49.215.8])by relay1.pgsql.com (Postfix) with ESMTPid 33CF26F7766; Tue, 18 Mar 2003 00:43:58 -0500 (EST)
Received: from joeconway.com (66-146-172-86.skyriver.net [66.146.172.86])by postgresql.org (Postfix) with ESMTP id 4CC53474E4Ffor <[EMAIL PROTECTED]>; Tue, 18 Mar 2003 00:43:47 -0500 (EST)
Received: from [192.168.5.3] (account jconway HELO joeconway.com) by joeconway.com (CommuniGate Pro SMTP 4.0.4) with ESMTP-TLS id 1667227; Mon, 17 Mar 2003 22:19:54 -0800
X-Message-Info: JGTYoYF78jEHjJx36Oi8+Q1OJDRSDidP
X-Original-To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130
X-Accept-Language: en-us, en
References: <[EMAIL PROTECTED]>
In-Reply-To: <[EMAIL PROTECTED]>
Precedence: bulk
Sender: [EMAIL PROTECTED]
Return-Path: [EMAIL PROTECTED]
X-OriginalArrivalTime: 18 Mar 2003 05:44:00.0021 (UTC) FILETIME=[5FF98450:01C2ED11]

Key88 SF wrote:
I suppose that is ok. But the default compiler flags in the provided makefile for libpq is non-multithreaded. That should at least be fixed I would think.

If it's not a big deal for you, I would say that in the name of safety for those people who don't look closely at these things, it would be better to have the callback function to delete the memory and not have to assume libpq is built with the correct c-runtimes...


Since you know exactly what's needed, and a project that needs it, why don't you submit a patch? ;-)

Joe




---------------------------(end of broadcast)--------------------------- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


_________________________________________________________________
The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

Attachment: freebytea.zip
Description: Zip compressed data

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
    (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])

Reply via email to