On Thu, Jan 12, 2017 at 5:39 PM, Rahila Syed <rahilasye...@gmail.com> wrote: > Hello, > > On applying the patch on latest master branch and running regression tests > following failure occurs. > I applied it on latest parallel index scan patches as given in the link > above. > > *** > /home/rahila/postgres/postgres/src/test/regress/expected/select_parallel.out > 2017-01-03 14:06:29.122022780 +0530 > --- > /home/rahila/postgres/postgres/src/test/regress/results/select_parallel.out > 2017-01-12 14:35:56.652712622 +0530 > *************** > *** 92,103 **** > explain (costs off) > select sum(parallel_restricted(unique1)) from tenk1 > group by(parallel_restricted(unique1)); > ! QUERY PLAN > ! ---------------------------------------------------- > HashAggregate > Group Key: parallel_restricted(unique1) > ! -> Index Only Scan using tenk1_unique1 on tenk1 > ! (3 rows) > > set force_parallel_mode=1; > explain (costs off) > --- 92,105 ---- > explain (costs off) > select sum(parallel_restricted(unique1)) from tenk1 > group by(parallel_restricted(unique1)); > ! QUERY PLAN > ! ------------------------------------------------------------------- > HashAggregate > Group Key: parallel_restricted(unique1) > ! -> Gather > ! Workers Planned: 4 > ! -> Parallel Index Only Scan using tenk1_unique1 on tenk1 > ! (5 rows) > > IIUC, parallel operation being performed here is fine as parallel restricted > function occurs above Gather node > and just the expected output needs to be changed. >
True, fixed it, please find the attached file for the latest version. > Thank you, > Rahila Syed > Thanks a lot for the review Rahila. -- Regards, Rafia Sabih EnterpriseDB: http://www.enterprisedb.com/
parallel_index_only_v4.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers