> > > Ryan try to run 'make install-world' then 'make -i installcheck-world', -i > option will ignore the error and proceed. You can check if any other tests > fails. This is a separate issue, unrelated to this patch. I do not think > we should stop from changing the status because of this. > > Beena, when I try to run 'make install-world' I get a lot of errors from the 'osx' executable which I think has to do with building the SGML documentation:
make -C doc install make -C src install make -C sgml install { \ echo "<!ENTITY version \"10devel\">"; \ echo "<!ENTITY majorversion \"10\">"; \ } > version.sgml '/opt/local/bin/perl' ./mk_feature_tables.pl YES ../../../src/backend/catalog/sql_feature_packages.txt ../../../src/backend/catalog/sql_features.txt > features-supported.sgml '/opt/local/bin/perl' ./mk_feature_tables.pl NO ../../../src/backend/catalog/sql_feature_packages.txt ../../../src/backend/catalog/sql_features.txt > features-unsupported.sgml '/opt/local/bin/perl' ./generate-errcodes-table.pl ../../../src/backend/utils/errcodes.txt > errcodes-table.sgml /usr/local/bin/osx -D. -x lower -i include-xslt-index postgres.sgml >postgres.xmltmp /usr/local/bin/osx:postgres.sgml:3:55:W: cannot generate system identifier for public text "-//OASIS//DTD DocBook V4.2//EN" /usr/local/bin/osx:postgres.sgml:12:0:E: reference to entity "BOOK" for which no system identifier could be generated /usr/local/bin/osx:postgres.sgml:3:0: entity was defined here /usr/local/bin/osx:postgres.sgml:12:0:E: DTD did not contain element declaration for document type name /usr/local/bin/osx:postgres.sgml:14:9:E: there is no attribute "ID" /usr/local/bin/osx:postgres.sgml:14:19:E: element "BOOK" undefined /usr/local/bin/osx:postgres.sgml:15:7:E: element "TITLE" undefined /usr/local/bin/osx:postgres.sgml:17:10:E: element "BOOKINFO" undefined /usr/local/bin/osx:postgres.sgml:18:13:E: element "CORPAUTHOR" undefined /usr/local/bin/osx:postgres.sgml:19:14:E: element "PRODUCTNAME" undefined /usr/local/bin/osx:postgres.sgml:20:16:E: element "PRODUCTNUMBER" undefined /usr/local/bin/osx:legal.sgml:3:5:E: element "DATE" undefined /usr/local/bin/osx:legal.sgml:5:10:E: element "COPYRIGHT" undefined /usr/local/bin/osx:legal.sgml:6:6:E: element "YEAR" undefined ... /usr/local/bin/osx:history.sgml:173:13:E: element "LISTITEM" undefined /usr/local/bin/osx:history.sgml:174:10:E: element "PARA" undefined /usr/local/bin/osx:history.sgml:175:14:E: element "ACRONYM" undefined /usr/local/bin/osx:I: maximum number of errors (200) reached; change with -E option make[3]: *** [postgres.xml] Error 1 make[2]: *** [install] Error 2 make[1]: *** [install] Error 2 make: *** [install-world-doc-recurse] Error 2 Jim Nasby said I shouldn't necessarily need to build the docs / the whole world in order to review patches. But the Review form needs a `make installworld-check`. Do I need to install the whole world in order to meet this requirement? Happy to do so if required, but in that case, I wonder why 'osx' is having so much trouble parsing the SGML into XML? Thanks for the help, Ryan