On Wed, Jan 18, 2017 at 6:25 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Mon, Jan 16, 2017 at 11:11 PM, Amit Kapila <amit.kapil...@gmail.com> > wrote: >> >> >> Changed as per suggestion. >> >> >> I have also rebased the optimizer/executor support patch >> (parallel_index_opt_exec_support_v4.patch) and added a test case in >> it. > > > Thanks for the patch. Here are comments found during review. > > parallel_index_scan_v4.patch: > > > + amtarget = (char *) ((void *) target) + offset; > > The above calcuation can be moved after NULL check? > > + * index_beginscan_parallel - join parallel index scan > > The name and the description doesn't sync properly, any better description? > > + BTPARALLEL_DONE, > + BTPARALLEL_IDLE > +} PS_State; > > The order of above two enum values can be changed according to their use. >
Changed code as per your suggestion. > > parallel_index_opt_exec_support_v4.patch: > > +#include "access/parallel.h" > > Why is it required to be include nbtree.c? i didn't find > any code changes in the patch. > Removed. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers