On 20/01/17 15:08, Peter Eisentraut wrote: > On 1/19/17 5:01 PM, Petr Jelinek wrote: >> There were some conflicting changes committed today so I rebased the >> patch on top of them. >> >> Other than that nothing much has changed, I removed the separate sync >> commit patch, included the rename patch in the patchset and fixed the >> bug around pg_subscription catalog reported by Erik Rijkers. > > Committed. I haven't reviewed the rename patch yet, so I'll get back to > that later. >
Hi, Thanks! Here is fix for the dependency mess. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c index 21e523d..9791f43 100644 --- a/src/backend/commands/publicationcmds.c +++ b/src/backend/commands/publicationcmds.c @@ -236,6 +236,8 @@ CreatePublication(CreatePublicationStmt *stmt) heap_close(rel, RowExclusiveLock); + recordDependencyOnOwner(PublicationRelationId, puboid, GetUserId()); + InvokeObjectPostCreateHook(PublicationRelationId, puboid, 0); return myself; diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index 1448ee3..00f2a5f 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -313,6 +313,8 @@ CreateSubscription(CreateSubscriptionStmt *stmt) ObjectAddressSet(myself, SubscriptionRelationId, subid); + recordDependencyOnOwner(SubscriptionRelationId, subid, GetUserId()); + InvokeObjectPostCreateHook(SubscriptionRelationId, subid, 0); return myself; @@ -493,6 +495,10 @@ DropSubscription(DropSubscriptionStmt *stmt) ReleaseSysCache(tup); + /* Clean up the depenencies. */ + deleteSharedDependencyRecordsFor(SubscriptionRelationId, subid, + InvalidOid); + /* Protect against launcher restarting the worker. */ LWLockAcquire(LogicalRepLauncherLock, LW_EXCLUSIVE);
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
