On 01/24/2017 03:18 AM, Andrew Dunstan wrote: > > On 01/23/2017 09:22 AM, Tom Lane wrote: >> Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >>> On 01/23/2017 09:03 AM, Tom Lane wrote: >>>> Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >>>>> On 01/20/2017 01:22 PM, Tom Lane wrote: >>>>>> It looks like at least part of the answer is that the buildfarm isn't >>>>>> running this test. AFAICS, it runs "make installcheck" not >>>>>> "make check" in src/test/modules. >>> OK, so should we just change "make installcheck" to "make check"? >> I'm in favor (just for src/test/modules, to be clear). >> >> > > > Yes. There will be some consequent buildfarm code cleanup, but this will > test shortly on crake. >
Well, that crashed. The DDL deparse comment test should not assume that contrib_regression exists. Possibly it should create it if it doesn't exist. The buildfarm mostly runs with USE_DB_MODULE=1 so we don't constantly overwrite the same db. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers