Peter, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 1/19/17 11:03 AM, Stephen Frost wrote: > > I'd suggest using our usual approach in pg_dump, which is matching based > > on the OID, like so: > > > > WHERE c.oid = '%u'::oid > > > > The OID is in: tbinfo->dobj.catId.oid > > > > Also, you should move the selectSourceSchema() into the per-version > > branches and set it to 'pg_catalog' for PG10 and up, which would allow > > you to avoid having to qualify the table names, et al. > > Does the attached patch look correct to you?
On a one-over, yes, that looks correct and avoids the issue of running in a user's schema. It wouldn't hurt to add a comment as to why things are so different in PG10 than other versions, ie: /* * In PG10, sequence meta-data was moved into pg_sequence, so switch to * the pg_catalog schema instead of operating in a user schema and pull * the necessary meta-data from there. */ Thanks! Stephen
signature.asc
Description: Digital signature
