On 1/27/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Updated patches are attached.
Hello, I'm almost ready to mark it as Ready for committer. The final round. 1. >+DATA(insert OID = 774 ( macaddr8 ... >+#define MACADDR8OID 972 What does this number (972) mean? I think it should be 774, the same number as was used in the type definition. Since there is an editing required, please, fix whitespaces: 2. >+DATA(insert OID = 3371 ( 403 macaddr8_ops >PGNSP PGUID )); >+DATA(insert OID = 3372 ( 405 macaddr8_ops >PGNSP PGUID )); only one (not three) tab before "PGNSP" should be used (see other rows around yours: "OID = 1983", "OID = 1991" etc). 3. >diff --git a/contrib/btree_gist/Makefile b/contrib/btree_gist/Makefile some new rows have two tabs instead of eight spaces. 4. Some other files need to be fixed by pgindent (it helps supporting in the future): contrib/btree_gist/btree_macaddr8.c (a lot of rows) src/include/utils/inet.h (I have no idea why it changes indentation to tabs for macaddr8 whereas it leaves spaces for macaddr) 5. src/backend/utils/adt/network.c pg_indent makes it uglier. I've just found how to write the line for it: res *= ((double) 256) * 256 * 256 * 256; -- Best regards, Vitaly Burovoy -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
