On Thu, Feb 2, 2017 at 6:29 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> >> + ptr = (char *) itup + IndexInfoFindDataOffset(itup->t_info); >> + Assert(ptr <= uargs->page + BLCKSZ); >> >> I think this should be promoted to an ereport(); these functions can >> accept an arbitrary bytea. > > I think we had added 'ptr' variable initially just to dump hash code > in hexadecimal format but now since we have removed that logic from > current code, I think it is no more required and I have therefore > removed it from the current patch. Below is the code that used it > initially. It got changed as per your comment - [1]
OK. > I think it's OK to check hash_bitmap_info() or any other functions > with different page types at least once. > > [1]- > https://www.postgresql.org/message-id/CA%2BTgmoZUjrVy52TUU3b_Q5L6jcrt7w5R4qFwMXdeCuKQBmYWqQ%40mail.gmail.com Sure, I just don't know if we need to test them 4 or 5 times. But I think this is good enough for now - it's not like this code is written in stone once committed. So, committed. Wow, I wish every patch had this many reviewers. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
