Hello. Good to know that the work on this great feature continues!
However this set of patches does not pass `make check-world` on my laptop. Here is how I build and test PostgreSQL: https://github.com/afiskon/pgscripts/blob/master/full-build.sh Error message: http://afiskon.ru/s/0b/258c6e4f14_123.txt regression.diffs: http://afiskon.ru/s/a0/4993102c32_regression.diffs.txt regression.out: http://afiskon.ru/s/4b/acd5a58374_regression.out.txt Backtrace: http://afiskon.ru/s/00/c0b32b45a6_bt.txt I'm using Arch Linux with latest updates, Python version is 3.6.0. I have no idea what SCRAM has to do with Python, but this issue reproduced two times of two I did `make check-world`. There is no such issue in current master branch. On Mon, Feb 06, 2017 at 02:55:08PM +0200, Heikki Linnakangas wrote: > I rebased the SCRAM authentication patches over current master. Here you > are. > > I'm trying to whack this into the final shape that it could actually be > committed. The previous thread on SCRAM authentication has grown > ridiculously long and meandered into all kinds of details, so I thought it's > best to start afresh with a new thread. > > So, if you haven't paid attention on this for a while, now would be a good > time to have another look at the patch. I believe all the basic > functionality, documentation, and tests are there, and there are no known > bugs. Please review! I'll start reading through these myself again tomorrow. > > One thing that's missing, that we need to address before the release, is the > use of SASLPrep to "normalize" the password. We discussed that in the > previous thread, and I think we have a good path forward on it. I'd be happy > to leave that for a follow-up commit, after these other patches have been > committed, so we can discuss that work separately. > > These are also available on Michael's github repository, at > https://github.com/michaelpq/postgres/tree/scram. > > - Heikki > -- Best regards, Aleksander Alekseev
signature.asc
Description: PGP signature
