On Tue, Feb 14, 2017 at 6:51 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > +#if SIZEOF_DSA_POINTER == 4 > +typedef uint32 dsa_pointer; > +#else > +typedef uint64 dsa_pointer; > +#endif > > I feel the declaration of the above typdef can be moved into the > section above if we going with the current move into postgres.h > file.
Robert has already given the patch[1] for the same so now don't need to do anything for this. Therefore, I included the dsa.h in tidbitmap.h. [1] https://www.postgresql.org/message-id/CA%2BTgmoZ%3DF%3DGkxV0YEv-A8tb%2BAEGy_Qa7GSiJ8deBKFATnzfEug%40mail.gmail.com > > +/* > + * tbm_alloc_shared > + * > + * Callback function for allocating the memory for hashtable elements. > + * It allocates memory from DSA if tbm holds a reference to a dsa. > + */ > +static inline void * > +pagetable_allocate(pagetable_hash *pagetable, Size size) > > Function name and comments mismatch? Fixed. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
0001-tidbitmap-support-shared-v2.patch
Description: Binary data
0002-parallel-bitmap-heapscan-v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
