On Thu, Mar 2, 2017 at 8:25 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > I wonder why we allow that. Shouldn't the tid type reject input that > has ip_posid == 0?
InvalidOffsetNumber (that is, 0) is something that I wouldn't like to bet doesn't make it out to disk at some point. I know that we use 1 as a meaningless placeholder value for internal B-Tree pages. P_HIKEY is where I get 1 from, which might as well be any other value in practice, I think -- we only need an item pointer to point to a block from an internal page. SpecTokenOffsetNumber can certainly make it to disk, and that is invalid in some sense, even if it isn't actually set to InvalidOffsetNumber. So, seems pretty risky to me. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
