On 03/03/17 01:53, Erik Rijkers wrote: > On 2017-03-03 01:30, Petr Jelinek wrote: > > With these patches: > > 0001-Use-asynchronous-connect-API-in-libpqwalreceiver.patch > 0002-Fix-after-trigger-execution-in-logical-replication.patch > 0003-Add-RENAME-support-for-PUBLICATIONs-and-SUBSCRIPTION.patch > snapbuild-v5-0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch > snapbuild-v5-0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch > > snapbuild-v5-0003-Prevent-snapshot-builder-xmin-from-going-backwards.patch > snapbuild-v5-0004-Fix-xl_running_xacts-usage-in-snapshot-builder.patch > snapbuild-v5-0005-Skip-unnecessary-snapshot-builds.patch > 0001-Logical-replication-support-for-initial-data-copy-v6.patch > > I get: > > subscriptioncmds.c:47:12: error: static declaration of ‘oid_cmp’ follows > non-static declaration > static int oid_cmp(const void *p1, const void *p2); > ^~~~~~~ > In file included from subscriptioncmds.c:42:0: > ../../../src/include/utils/builtins.h:70:12: note: previous declaration > of ‘oid_cmp’ was here > extern int oid_cmp(const void *p1, const void *p2); > ^~~~~~~ > make[3]: *** [subscriptioncmds.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > make[2]: *** [commands-recursive] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [all-backend-recurse] Error 2 > make: *** [all-src-recurse] Error 2 >
Yes the copy patch needs rebase as well. But these ones are fine. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
