On Sat, 4 Mar 2017 14:26:54 +0530 Robert Haas <[email protected]> wrote:
> On Fri, Mar 3, 2017 at 7:21 PM, Karl O. Pinc <[email protected]> wrote: > > But if the code does not exit the loop then > > before calling elog(ERROR), shouldn't it > > also call FreeFile(fd)? > > Hmm. Normally error recovery cleans up opened files, but since > logfile_open() directly calls fopen(), that's not going to work here. > So that does seem to be a problem. Should something different be done to open the file or is it enough to call FreeFile(fd) to clean up properly? Karl <[email protected]> Free Software: "You don't pay back, you pay forward." -- Robert A. Heinlein -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
