* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > * Giuseppe Broccolo (giuseppe.brocc...@2ndquadrant.it) wrote: > >> I've seen that pg_dump execute the dump of an eventual comment of a > >> TSDictionary without specifying the namespace where it is defined: > > > Great catch! > > One of my smarter CS professors taught me that whenever you find a bug, > you should look around to see where else you made the same mistake.
Indeed, was planning to do so. > Checking for other errors of the same ilk is depressingly fruitful :-( Ah, ouch. > It looks to me like operator classes, operator families, and all four > types of text-search objects have this same error, and have for a long > time. I'm also wondering if it wouldn't be wise for the dumpComment() > call for procedural languages to use "lanschema", so that the comment > TocEntry matches the parent object in both cases for PL objects. That does sound like a good idea.. > I'm also kind of wondering why the ArchiveEntry() calls for casts and > transforms specify "pg_catalog" as the schema but we don't do that in > their dumpComment() calls. Maybe we don't need that hack and should > specify NULL instead. Hmmm, probably, though I've not looked specifically. > > Right. I've got a few other patches queued up for pg_dump, so I'll > > take care of this also. > > Do you want to deal with this whole mess, or shall I have a go at it? I'm just about to push the pg_upgrade fixes for large object comments and security labels, followed not too far behind by the fix for the public ACL in pg_dump --clean mode. I have no objection to you handling these and I can go look at some of the other items on my plate. Thanks! Stephen
signature.asc
Description: Digital signature
