On Mon, Mar 6, 2017 at 12:12 PM, Yugo Nagata <nag...@sraoss.co.jp> wrote: > Hi, > > I think this is good since the information is useful and it is > a little change.
Thank you for reviewing this patch! > > One thing I'm bothered is that even when the number of frozen page is > one, it will say "1 frozen pages". In other messages, when the > number of page is one, the word "page" rather than "pages" is used > by using ngettext(). I don't think it can say "1 frozen pages" because the number of skipped pages according to visibility map is always more than 32 (SKIP_PAGES_THRESHOLD). > > In addition, the document (doc/src/sgml/ref/vacuum.sgml) need a modification > to use the new messages in its example. Fixed. > > BTW, this patch can't be applied after the following commit. > > commit 9eb344faf54a849898d9be012ddfa8204cfeb57c > Author: Simon Riggs <si...@2ndquadrant.com> > Date: Fri Mar 3 19:18:25 2017 +0530 > > Allow vacuums to report oldestxmin Attached updated v2 patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
report_frozen_skipped_pages_v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
