Hello Amit, On Tue, Mar 7, 2017 at 4:24 PM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > Hi Kuntal, > > Patches apply and compile fine. Works as advertised. > > Some minor comments on the patches themselves. > Thanks for the review.
> In 0001:
>
> - * pgstat_bestart() -
> + * pgstat_procstart() -
> + *
> + * Initialize this process's entry in the PgBackendStatus array.
> + * Called from InitPostgres and AuxiliaryProcessMain.
>
> Not being called from AuxiliaryProcessMain(). Maybe leftover comment from
> a previous version. Actually I see that in patch 0002, Main() functions
> of various auxiliary processes call pgstat_procstart, not
> AuxiliaryProcessMain.
>
Fixed.
> + * user-defined functions which expects ids of backends starting from
> 1 to
>
> s/expects/expect/g
>
Fixed.
> +/*
> + * AuxiliaryPidGetProc -- get PGPROC for an auxiliary process
> + * given its PID
> + *
> + * Returns NULL if not found.
> + */
> +PGPROC *
> +AuxiliaryPidGetProc(int pid)
> +{
> + PGPROC *result;
>
> Initialize to NULL so that the comment above is true. :)
>
Fixed.
> In 0002:
>
> @@ -248,6 +248,9 @@ BackgroundWriterMain(void)
> */
> prev_hibernate = false;
>
> + /* report walwriter process in the PgBackendStatus array */
> + pgstat_procstart();
> +
>
> s/walwriter/writer/g
Fixed.
> Patch 0004 should update monitoring.sgml.
Added.
I've attached the updated patches. PFA.
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com
0001-Infra-to-expose-non-backend-processes-in-pg_stat_get.patch
Description: binary/octet-stream
0002-Expose-stats-for-auxiliary-processes-in-pg_stat_get_.patch
Description: binary/octet-stream
0003-Expose-stats-for-autovacuum-launcher-and-bgworker.patch
Description: binary/octet-stream
0004-Add-proc_type-column-in-pg_stat_get_activity.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
