On Fri, Mar 10, 2017 at 8:12 AM, Amit Khandekar <amitdkhan...@gmail.com> wrote: >> +static inline void >> +exec_append_scan_first(AppendState *appendstate) >> +{ >> + appendstate->as_whichplan = 0; >> +} >> >> I don't think this is buying you anything, and suggest backing it out. > > This is required for sequential Append, so that we can start executing > from the first subplan.
My point is that there's really no point in defining a static inline function containing one line of code. You could just put that line of code in whatever places need it, which would probably be more clear. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers