> > Thanks for catching that. > It was caused by a conflict on applying of the patch. > Updated versions of both patches are attached. >
We do not need extra line <variablelist> + + <varlistentry> other usages of this do not have an extra line. Removed the extra line in the attached patch. I noticed that the earlier error message was using "server" instead of "foreign server", while the new message uses the later one. Usually, when converting an error to notice, we don't expect such changes. But many other error messages are using "foreign server" instead of "server", so probably this one needed a change anyway. But then, the command to create a foreign server is not "CREATE FOREIGN SERVER", it's "CREATE SERVER", so users are already getting confused? I don't see similar change in the error message for the user mapping. Do we need to change "server" to "foreign server" in case of user mapping? The doc changes didn't compile with error "osx:ref/create_user_mapping.sgml:52:15:E: document type does not allow element "VARLISTENTRY" here; assuming missing "VARIABLELIST" start-tag". The user mappings do not have name so the doc change was slightly incorrect when it said "Do not throw an error if a user mapping with the same name already exists.". I have corrected both these things in the attached patch. Other changes look good. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
create_user_mapping_if_not_exists_3.0.patch
Description: Binary data
create_foreign_server_if_not_exists_3.0.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
