On Thu, Mar 16, 2017 at 7:19 AM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Thu, Mar 16, 2017 at 7:10 AM, Robert Haas <robertmh...@gmail.com> wrote: >> So I am looking at this part of 0008: >> >> + /* >> + * Do not copy parent_rinfo and child_rinfos because 1. they create a >> + * circular dependency between child and parent RestrictInfo 2. >> dropping >> + * those links just means that we loose some memory >> optimizations. 3. There >> + * is a possibility that the child and parent RestrictInfots >> themselves may >> + * have got copied and thus the old links may no longer be valid. The >> + * caller may set up those links itself, if needed. >> + */ >> >> I don't think that it's very clear whether or not this is safe. I >> experimented with making _copyRestrictInfo PANIC, > > I am not able to understand how to make _copyRestrictInfo PANIC. Can > you please share the patch or compiler flags or settings? I will look > at the case below once I have that.
I just put elog(PANIC, "_copyRestrictInfo") into the function. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
