On Fri, Mar 17, 2017 at 7:18 PM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi, > > Am Freitag, den 17.03.2017, 10:50 +0900 schrieb Michael Paquier: >> The comment block format is incorrect. I would think as well that this >> comment should say it is important to have the main tablespace listed >> last it includes the WAL segments, and those need to contain all the >> latest WAL segments for a consistent backup. > > How about the attached? The comment now reads as follows: > > |Add a node for the base directory. If WAL is included, the base > |directory has to be last as the WAL files get appended to it. If WAL > |is not included, send the base directory first, so that the > |backup_label file is the first file to be sent.
Close enough, still not that: https://www.postgresql.org/docs/current/static/source-format.html >> FWIW, I have no issue with changing the ordering of backups the way >> you are proposing here as long as the comment of this code path is >> clear. > > OK, great, let's see what the committers think then. Still that's a minor point, so I am making that ready for committer. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
