On 19 March 2017 at 21:12, Craig Ringer <cr...@2ndquadrant.com> wrote:
> Rebased attached. Patch1 looks good to go. I'll correct a spelling mistake in the tap test when I commit that later today. Patch2 has a couple of points 2.1 Why does call to ReplicationSlotAcquire() move earlier in pg_logical_slot_get_changes_guts()? 2.2 sendTimeLineIsHistoric looks incorrect, and at least isn't really documented well. The setting sendTimeLineIsHistoric = state->currTLI == ThisTimeLineID; should be sendTimeLineIsHistoric = (state->currTLI != ThisTimeLineID); but that doesn't cause failure because in read_local_xlog_page() we say that we are reading from history when state->currTLI != ThisTimeLineID explicitly rather than use sendTimeLineIsHistoric So it looks like we could do with a few extra comments If you correct these I'll commit it tomorrow. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
