Hello, On 19.03.2017 21:45, Michael Banck wrote:
So the patch I sent earlier creates the slot in ReceiveXlogStream() in receivewal.c, as that's where the temp slot gets created as well, but now I wonder whether that is maybe not the best place, as pg_receivewal also calls that function. The other problem with receivewal.c is that `verbose' isn't around in it so I don't how I'd print out a message there. So probably it is better to create the slot in pg_basebackup.c's StartLogStreamer(), see the attached first patch, that one also adds a verbose message.
I think such too. I suppose it is more clearly. StartLogStreamer() is better place for creating permanent and temporary slots.
Also maybe it would be good if pg_basebackup had a way to drop created slot. Although "drop slot" is not related with concept of automatically created slots, it will good if user will have a way to drop slots.
-- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
