>> While working on - [1], I realised that the following comments in >> _hash_alloc_buckets() needs to be corrected. >> >> /* >> * Initialize the freed overflow page. Just zeroing the page won't work, >> * See _hash_freeovflpage for similar usage. >> */ >> _hash_pageinit(page, BLCKSZ); >> >> Attached is the patch that corrects above comment. Thanks. >> > > - * Initialize the freed overflow page. Just zeroing the page won't work, > + * Initialize the last page in hash index. > > I think saying ".. last page in hash index" sounds slightly awkward as > this is the last page for current split point, how about just > "Initialize the page. ..."
Yes, I mean just adding "Initialize the page. ..." looks more simple and correct. Attached is the patch with similar comment.
diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index 622cc4b..4fd9cbc 100644 --- a/src/backend/access/hash/hashpage.c +++ b/src/backend/access/hash/hashpage.c @@ -1002,7 +1002,7 @@ _hash_alloc_buckets(Relation rel, BlockNumber firstblock, uint32 nblocks) page = (Page) zerobuf; /* - * Initialize the freed overflow page. Just zeroing the page won't work, + * Initialize the page. Just zeroing the page won't work, * See _hash_freeovflpage for similar usage. */ _hash_pageinit(page, BLCKSZ);
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
