At Fri, 31 Mar 2017 16:17:05 +0900, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote in <2dec1acb-6e2f-5aa5-0e26-fcc172ce9...@lab.ntt.co.jp> > Horiguchi-san, > > On 2017/03/31 15:50, Kyotaro HORIGUCHI wrote: > > At Thu, 30 Mar 2017 20:58:35 +0900, Amit Langote wrote: > >> Updated patch attached. > > > > Thank you. > > > > - Applies cleanly on master (f90d23d) > > - Compiled without error > > - Code seems fine. > > - Documentaion seems fine.. for me. > > - Passes regression test. > > - Leaving the ALTER-on-toast.* problem is fine for me. > > Thanks for the review. > > > The regression contains the tests to fail with several reloptions > > only for partitioned tables. Are they still required even though > > it is now in the same framework with other kind of reloptions? > > Hmm, maybe we don't really need those tests, so removed.
I have no more comment on this. Thank you. regards, -- Kyotaro Horiguchi NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
