> On Apr 5, 2017, at 1:12 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Mark Dilger <hornschnor...@gmail.com> writes: >> I have written a patch to fix these macro definitions across src/ and >> contrib/. >> Find the patch, attached. All regression tests pass on my Mac laptop. > > Thanks for doing the legwork on that.
You are welcome. > This seems a bit late for v10, > especially since it's only cosmetic Agreed. > , but please put it in the first > v11 commitfest. Done. > >> I don't find any inappropriate uses of _P where _PP would be called for. I >> do, >> however, notice that some datatypes' functions are written to use >> PG_GETARG_*_P >> where PG_GETARG_*_PP might be more efficient. > > Yeah. I think Noah did some work in that direction already, but I don't > believe he claimed to have caught everything. Feel free to push further. Thanks for clarifying. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
