On Thu, Apr 13, 2017 at 11:05 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Apr 12, 2017 at 11:48 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Wed, Apr 12, 2017 at 5:12 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> Hi, >>> >>> I've attached a patch for $subject. Please check it. >> >> + COMPLETE_WITH_LIST8("WITH", "CONNECTION", "SET PUBLICATION", "ENABLE", >> + "DISABLE", "OWNER TO", "RENAME TO", "REFRESH PUBLICATION WITH"); >> >> "WITH" should be "WITH ("? >> Also "REFRESH PUBLICATION WITH" should be "REFRESH PUBLICATION WITH ("? > > Agreed. I found other bugs of tab completion of PUB/SUB DDLs. Attached > latest patch incorporated these fixes.
Thanks for the patch! Pushed. >> BTW, I found that ALTER SUBSCRIPTION ... RENAME TO exists in tab-complete.c, >> but not in the documentation. ALTER PUBLICATION has the same issue, too. >> So I think that we need to apply the attached patch which improves the >> documentation >> for ALTER PUBLICATION and SUBSCRIPTION. > > +1 Also pushed. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers